Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: tools/create_sdk.py

Issue 11238047: Add a version file to the SDK (in preparation for eventually removing the revision file). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « README.dart-sdk ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/create_sdk.py
===================================================================
--- tools/create_sdk.py (revision 13891)
+++ tools/create_sdk.py (working copy)
@@ -87,7 +87,7 @@
# TODO(zundel): this excludes the analyzer from the sdk build until builders
# have all prerequisite software installed. Also update dart.gyp.
def ShouldCopyAnalyzer():
- os = utils.GuessOS();
+ os = utils.GuessOS()
return os == 'linux' or os == 'macos'
@@ -116,9 +116,9 @@
Copy(os.path.join(build_dir, 'dartdoc.bat'), dartdoc)
# TODO(dgrove) - fix this once issue 4788 is addressed.
ReplaceInFiles([dart2js],
- [(r'%SCRIPTPATH%\.\.\\\.\.\\lib', r'%SCRIPTPATH%..\\pkg')]);
+ [(r'%SCRIPTPATH%\.\.\\\.\.\\lib', r'%SCRIPTPATH%..\\pkg')])
ReplaceInFiles([dartdoc],
- [(r'%SCRIPTPATH%\.\.\\\.\.\\pkg', r'%SCRIPTPATH%..\\pkg')]);
+ [(r'%SCRIPTPATH%\.\.\\\.\.\\pkg', r'%SCRIPTPATH%..\\pkg')])
else:
dart2js = os.path.join(sdk_root, 'bin', 'dart2js')
Copy(os.path.join(build_dir, 'dart2js'), dart2js)
@@ -309,11 +309,11 @@
join("guava", "r09", "guava-r09.jar"),
join("json", "r2_20080312", "json.jar") ]
for jarToCopy in jarsToCopy:
- dest_dir = join (ANALYZER_DEST, os.path.dirname(jarToCopy))
- os.makedirs(dest_dir)
- dest_file = join (ANALYZER_DEST, jarToCopy)
- src_file = join(ANALYZER_HOME, 'util', 'analyzer', jarToCopy)
- copyfile(src_file, dest_file)
+ dest_dir = join (ANALYZER_DEST, os.path.dirname(jarToCopy))
+ os.makedirs(dest_dir)
+ dest_file = join (ANALYZER_DEST, jarToCopy)
+ src_file = join(ANALYZER_HOME, 'util', 'analyzer', jarToCopy)
+ copyfile(src_file, dest_file)
# Create and populate util/pub.
copytree(join(HOME, 'utils', 'pub'), join(UTIL, 'pub'),
@@ -337,9 +337,14 @@
# Copy dart2js.
CopyDart2Js(build_dir, SDK_tmp, version)
+ # Write the 'version' file
+ versionFile = open(os.path.join(SDK_tmp, 'version'), 'w')
+ versionFile.write(version + '\n')
+ versionFile.close()
+
+ # Write the 'revision' file
revision = utils.GetSVNRevision()
- # Write the 'revision' file
if revision is not None:
with open(os.path.join(SDK_tmp, 'revision'), 'w') as f:
f.write(revision + '\n')
« no previous file with comments | « README.dart-sdk ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698