Start a whitelist of methods those optionals should be treated as named formals in dart:html.

Start a whitelist of methods those optionals should be treated as named formals in dart:html.

R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com,vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=13925

[blois, 2012-10-19 19:40:45]

lgtm

[Emily Fortuna, 2012-10-19 19:48:34]

lgtm

https://codereview.chromium.org/11236008/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11236008/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:36: 
nit: probably don't need two lines of whitespace here.

[vsm, 2012-10-19 19:53:28]

https://codereview.chromium.org/11236008/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11236008/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:39: ])
One thing that worries me about named params is that we get the names from IDL
and they're practically comments there - no semantic value in JS.  They might
change arbitrarily.

Perhaps we can handle that by explicitly listing the optional params here with a
map from IDL parameter name to Dart name.  If the IDL name changes, fail and
force us to fix us here.  This would be a way to keep Dart names stable.

What do you guys think?

[Emily Fortuna, 2012-10-19 19:57:59]

good point. sgtm

[Anton Muhin, 2012-10-23 13:59:52]

https://codereview.chromium.org/11236008/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11236008/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:39: ])
That's true, but my feeling is the chance of parameter name change is roughly
the same (or even less) as of method/interface.

Would you mind if we live for some time with names from IDLs and if we find them
not stable enough, resort to separate database for names?

On 2012/10/19 19:53:28, vsm wrote:
> One thing that worries me about named params is that we get the names from IDL
> and they're practically comments there - no semantic value in JS.  They might
> change arbitrarily.
> 
> Perhaps we can handle that by explicitly listing the optional params here with
a
> map from IDL parameter name to Dart name.  If the IDL name changes, fail and
> force us to fix us here.  This would be a way to keep Dart names stable.
> 
> What do you guys think?