Start a whitelist of methods those optionals should be treated as named formals in dart:html.

lib/html/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import copy
 import re
@@ skipping 15 matching lines @@
     'SVGStylable',
     'SVGTests',
     'SVGTransformable',
     'SVGURIReference',
     'SVGZoomAndPan',
     'TimeoutHandler'])
 
 def IsPureInterface(interface_name):
   return interface_name in _pure_interfaces
 
+

[Emily Fortuna, 2012/10/19 19:48:34]

nit: probably don't need two lines of whitespace here.

+_methods_with_named_formals = set([
+  'DirectoryEntry.getDirectory',
+  ])

[vsm, 2012/10/19 19:53:28]

One thing that worries me about named params is that we get the names from IDL
and they're practically comments there - no semantic value in JS.  They might
change arbitrarily.

Perhaps we can handle that by explicitly listing the optional params here with a
map from IDL parameter name to Dart name.  If the IDL name changes, fail and
force us to fix us here.  This would be a way to keep Dart names stable.

What do you guys think?

[Anton Muhin, 2012/10/23 13:59:53]

That's true, but my feeling is the chance of parameter name change is roughly
the same (or even less) as of method/interface.

Would you mind if we live for some time with names from IDLs and if we find them
not stable enough, resort to separate database for names?

On 2012/10/19 19:53:28, vsm wrote:

+
 #
 # Renames for attributes that have names that are not legal Dart names.
 #
 _dart_attribute_renames = {
     'default': 'defaultValue',
     'final': 'finalValue',
 }
 
 #
 # Interface version of the DOM needs to delegate typed array constructors to a
@@ skipping 184 matching lines @@
   # to a dart argument.
   info = OperationInfo()
   info.operations = operations
   info.overloads = split_operations
   info.declared_name = operations[0].id
   info.name = operations[0].ext_attrs.get('DartName', info.declared_name)
   info.constructor_name = None
   info.js_name = info.declared_name
   info.type_name = operations[0].type.id   # TODO: widen.
   info.param_infos = _BuildArguments([op.arguments for op in split_operations], interface)
-  info.requires_named_arguments = False
+  full_name = '%s.%s' % (interface.id, info.declared_name)
+  info.requires_named_arguments = full_name in _methods_with_named_formals
   return info
 
 
 def AnalyzeConstructor(interface):
   """Returns an OperationInfo object for the constructor.
 
   Returns None if the interface has no Constructor.
   """
   if 'Constructor' in interface.ext_attrs:
     name = None
@@ skipping 832 matching lines @@
             self._database.GetInterface(type_name))
       else:
         dart_interface_name = type_name
       return InterfaceIDLTypeInfo(type_name, type_data, dart_interface_name)
 
     if type_data.clazz == 'ListLike':
       return ListLikeIDLTypeInfo(type_name, type_data, self.TypeInfo(type_data.item_type))
 
     class_name = '%sIDLTypeInfo' % type_data.clazz
     return globals()[class_name](type_name, type_data)