Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123413002: dart2js: build metadata-types lazily in the new emitter. (Closed)

Created:
5 years, 7 months ago by floitsch
Modified:
5 years, 7 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), Harry Terkelsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: build metadata-types lazily in the new emitter. Instead of building all types in the TYPES table eagerly, evaluate them lazily at first access. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45723

Patch Set 1 #

Patch Set 2 : Better name and comment. #

Total comments: 2

Patch Set 3 : Inline comment. #

Patch Set 4 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -13 lines) Patch
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 2 3 6 chunks +50 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
floitsch
5 years, 7 months ago (2015-05-06 21:39:03 UTC) #2
sra1
lgtm https://codereview.chromium.org/1123413002/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/1123413002/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode433 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:433: // $metadataTypeComment. Just put the comment here.
5 years, 7 months ago (2015-05-07 03:39:30 UTC) #3
floitsch
https://codereview.chromium.org/1123413002/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/1123413002/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode433 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:433: // $metadataTypeComment. On 2015/05/07 03:39:30, sra1 wrote: > Just ...
5 years, 7 months ago (2015-05-07 04:08:59 UTC) #4
floitsch
Needed to merge with Siggi's changes. I will commit on Monday, but maybe PTAL.
5 years, 7 months ago (2015-05-09 03:56:21 UTC) #5
sra1
still lgtm
5 years, 7 months ago (2015-05-11 16:37:44 UTC) #6
floitsch
5 years, 7 months ago (2015-05-12 00:39:10 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 45723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698