pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart - Issue 1123413002: dart2js: build metadata-types lazily in the new emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 1123413002: dart2js: build metadata-types lazily in the new emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merged Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/metadata_collector.dart ('k') | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

index 44cfc17730e65cb7a7a56a798ca907b8acde5107..78e6886205e491fe72aba767c166592d1324f879 100644

--- a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

@@ -176,8 +176,7 @@ class Emitter implements emitterTask.Emitter {

return js.js.expressionTemplateFor("$metadataAccess[#]");

case JsBuiltin.getType:

- String typesAccess = _emitter.generateEmbeddedGlobalAccessString(TYPES);

- return js.js.expressionTemplateFor("$typesAccess[#]");

+ return _emitter.templateForReadType;

default:

_compiler.internalError(NO_LOCATION_SPANNABLE,