Issue 11234062: Make endianness named argument for DataView accessors.

Issue 11234062: Make endianness named argument for DataView accessors. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
vsm, podivilov, Emily Fortuna, sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make endianness named argument for DataView accessors. R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13994

Patch Set 2 : #

Total comments: 3

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -68 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	2 chunks	+24 lines, -24 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	13 chunks	+24 lines, -24 lines	0 comments	Download
M	lib/html/scripts/generator.py	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	tests/html/typed_arrays_dataview_test.dart	View	2 chunks	+8 lines, -20 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://codereview.chromium.org/11234062/diff/2001/tests/html/typed_arrays_dataview_test.dart File tests/html/typed_arrays_dataview_test.dart (left): https://codereview.chromium.org/11234062/diff/2001/tests/html/typed_arrays_dataview_test.dart#oldcode42 tests/html/typed_arrays_dataview_test.dart:42: expect(dv.getInt16(0, false), equals(1023)); yes, it's mandatory now. On one ...

8 years, 2 months ago (2012-10-23 19:17:37 UTC) #1

blois

8 years, 2 months ago (2012-10-23 19:37:28 UTC) #2

Emily Fortuna

8 years, 2 months ago (2012-10-23 20:33:30 UTC) #3

lgtm

https://codereview.chromium.org/11234062/diff/2001/tests/html/typed_arrays_da...
File tests/html/typed_arrays_dataview_test.dart (left):

https://codereview.chromium.org/11234062/diff/2001/tests/html/typed_arrays_da...
tests/html/typed_arrays_dataview_test.dart:42: expect(dv.getInt16(0, false),
equals(1023));
On 2012/10/23 19:37:28, blois wrote:
> Seems acceptable to require that this be spelled out- using this is frequently
> the source of bugs (people using it when they should not), so being explicit
is
> probably good.
> 
> On 2012/10/23 19:17:37, Anton Muhin wrote:
> > yes, it's mandatory now.
> > 
> > On one hand I find it ways more readable.  On other hand, enforcing it looks
> > bad.
> > 
> > Thoughts?
> 

I agree with Pete. Better to have it explicitly than not have it, I think.

Expand Messages | Collapse Messages