Make endianness named argument for DataView accessors.

tests/html/typed_arrays_dataview_test.dart

Index: tests/html/typed_arrays_dataview_test.dart
diff --git a/tests/html/typed_arrays_dataview_test.dart b/tests/html/typed_arrays_dataview_test.dart
index 08029d8b68323ddc01adf5b36139bd7b0abd7968..2a486f0f50ec4cdf669e842f70192de38f92e415 100644
--- a/tests/html/typed_arrays_dataview_test.dart
+++ b/tests/html/typed_arrays_dataview_test.dart
@@ -37,18 +37,12 @@ main() {
       expect(dv.byteLength, equals(10 - 2));
 
       expect(dv.getInt16(0), equals(1023));
-      expect(dv.getInt16(0, false), equals(1023));
-      // OPTIONALS expect(dv.getInt16(0, littleEndian: false), equals(1023));
-      expect(dv.getInt16(0, false), equals(1023));

[Anton Muhin, 2012/10/23 19:17:37]

yes, it's mandatory now.

On one hand I find it ways more readable.  On other hand, enforcing it looks
bad.

Thoughts?

[blois, 2012/10/23 19:37:28]

Seems acceptable to require that this be spelled out- using this is frequently
the source of bugs (people using it when they should not), so being explicit is
probably good.

On 2012/10/23 19:17:37, Anton Muhin wrote:

[Emily Fortuna, 2012/10/23 20:33:34]

I agree with Pete. Better to have it explicitly than not have it, I think.

-      expect(dv.getInt16(0, true), equals(-253));
-      // OPTIONALS expect(dv.getInt16(0, littleEndian: true), equals(-253));
-      expect(dv.getInt16(0, true), equals(-253));
+      expect(dv.getInt16(0, littleEndian: false), equals(1023));
+      expect(dv.getInt16(0, littleEndian: true), equals(-253));
 
       expect(dv.getUint16(0), equals(1023));
-      // OPTIONALS expect(dv.getUint16(0, littleEndian: false), equals(1023));
-      expect(dv.getUint16(0, false), equals(1023));
-      // OPTIONALS expect(dv.getUint16(0, littleEndian: true), equals(0xFF03));
-      expect(dv.getUint16(0, true), equals(0xFF03));
+      expect(dv.getUint16(0, littleEndian: false), equals(1023));
+      expect(dv.getUint16(0, littleEndian: true), equals(0xFF03));
 
       dv.setInt16(2, -1);
       expect(dv.getInt16(2), equals(-1));
@@ -61,18 +55,12 @@ main() {
       var dv = new DataView(a1.buffer);
 
       expect(dv.getInt32(0), equals(1023));
-      expect(dv.getInt32(0, false), equals(1023));
-      // OPTIONALS expect(dv.getInt32(0, littleEndian: false), equals(1023));
-      expect(dv.getInt32(0, false), equals(1023));
-      expect(dv.getInt32(0, true), equals(-0xFD0000));
-      // OPTIONALS expect(dv.getInt32(0, littleEndian: true), equals(-0xFD0000));
-      expect(dv.getInt32(0, true), equals(-0xFD0000));
+      expect(dv.getInt32(0, littleEndian: false), equals(1023));
+      expect(dv.getInt32(0, littleEndian: true), equals(-0xFD0000));
 
       expect(dv.getUint32(0), equals(1023));
-      // OPTIONALS expect(dv.getUint32(0, littleEndian: false), equals(1023));
-      expect(dv.getUint32(0, false), equals(1023));
-      // OPTIONALS expect(dv.getUint32(0, littleEndian: true), equals(0xFF030000));
-      expect(dv.getUint32(0, true), equals(0xFF030000));
+      expect(dv.getUint32(0, littleEndian: false), equals(1023));
+      expect(dv.getUint32(0, littleEndian: true), equals(0xFF030000));
   });
 
 }