Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123343008: Implement raw list checks. (Closed)

Created:
5 years, 7 months ago by karlklose
Modified:
5 years, 7 months ago
Reviewers:
asgerf, sra1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 : Change to compiler. #

Patch Set 2 : Rebase test expectations. #

Patch Set 3 : Update test expectations. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3578 lines, -3834 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/type_test_emitter.dart View 2 chunks +40 lines, -11 lines 1 comment Download
M pkg/pkg.status View 1 2 1 chunk +49 lines, -49 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/samples.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 1 chunk +1797 lines, -2039 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 2 chunks +18 lines, -20 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 5 chunks +13 lines, -13 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 1 chunk +143 lines, -155 lines 0 comments Download
M tests/html/html.status View 1 2 1 chunk +146 lines, -144 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 1 chunk +38 lines, -38 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +884 lines, -912 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +346 lines, -351 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +93 lines, -93 lines 0 comments Download
M tests/utils/utils.status View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/pkg_tested/pkg_tested.status View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
karlklose
5 years, 7 months ago (2015-05-13 11:17:15 UTC) #8
asgerf
LGTM
5 years, 7 months ago (2015-05-13 11:26:19 UTC) #9
karlklose
Committed patchset #3 (id:160001) manually as 45762 (presubmit successful).
5 years, 7 months ago (2015-05-13 11:59:10 UTC) #10
sra1
5 years, 7 months ago (2015-05-13 19:17:00 UTC) #12
Message was sent while issue was closed. 
DBC

https://codereview.chromium.org/1123343008/diff/160001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_backend/codegen/type_test_emitter.dart (right):

https://codereview.chromium.org/1123343008/diff/160001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_backend/codegen/type_test_emitter.dart:36: return
identical(
This would be simpler and not need helper functions if templates where used.

return js.js('#.constructor === Array', value);

Powered by Google App Engine
This is Rietveld 408576698