pkg/compiler/lib/src/js_backend/codegen/codegen.dart - Issue 1123343008: Implement raw list checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1123343008: Implement raw list checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update test expectations. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

index a1b623fc25ece50a7c8c89729d428ab957b9f194..2998a5bc2f8db96bc219513f6f25360d220b7a74 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

@@ -358,7 +358,7 @@ class CodeGenerator extends tree_ir.StatementVisitor

giveup(node, 'type casts not implemented.');

}

DartType type = node.type;

- if (type is InterfaceType && type.typeArguments.isEmpty) {

+ if (type is InterfaceType && type.isRaw) {

glue.registerIsCheck(type, registry);

js.Expression value = visitExpression(node.receiver);

return emitSubtypeTest(node, value, type);