Issue 11231070: Fix bug in HTTP client request generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11231070: Fix bug in HTTP client request generation (Closed)

Created:
8 years, 2 months ago by Søren Gjesse

Modified:
8 years, 2 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bug in HTTP client request generation If an HTTP request with an empty path was done using the HttpClient (either for normal HTTP or for upgrading to web sockets) the generated HTTP request line was invalid. The empty path was used in the request line e.g. GET HTTP/1.1 instead of GET / HTTP/1.1 This is now fixed by using / if no path is specified. This is specified in RFC 2616 section 3.2.2. BUG=6185 R=ager@google.com Committed: https://code.google.com/p/dart/source/detail?r=13939

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -13 lines)			Patch
M	runtime/bin/http_impl.dart	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	runtime/bin/http_parser.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/websocket_impl.dart	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	tests/standalone/io/http_client_test.dart	View	1 chunk	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages