runtime/bin/http_parser.dart - Issue 11231070: Fix bug in HTTP client request generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/http_parser.dart

Issue 11231070: Fix bug in HTTP client request generation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/http_parser.dart

diff --git a/runtime/bin/http_parser.dart b/runtime/bin/http_parser.dart

index 2224e4b8716971efef2a71c5c902ae7004f49bed..571ce702496d493f2e83a5491d0470bb0a4311d6 100644

--- a/runtime/bin/http_parser.dart

+++ b/runtime/bin/http_parser.dart

@@ -234,6 +234,9 @@ class _HttpParser {

case _State.REQUEST_LINE_URI:

if (byte == _CharCode.SP) {

+ if (_uri_or_reason_phrase.length == 0) {

+ throw new HttpParserException("Invalid request URI");

+ }

_state = _State.REQUEST_LINE_HTTP_VERSION;

_httpVersionIndex = 0;

} else {

« no previous file with comments | « runtime/bin/http_impl.dart ('k') | runtime/bin/websocket_impl.dart » ('j') | no next file with comments »