Issue 11231015: Fixed failing 4_External_Functions_A01_t01 test, updated co19-runtime.status with triaged test bug …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11231015: Fixed failing 4_External_Functions_A01_t01 test, updated co19-runtime.status with triaged test bug … (Closed)

Created:
8 years, 2 months ago by Tom Ball

Modified:
8 years, 2 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed failing 4_External_Functions_A01_t01 test, updated co19-runtime.status with triaged test bug numbers. BUG=5430 Committed: https://code.google.com/p/dart/source/detail?r=13843

Patch Set 2 : Use ZoneHandle for function name, instead of Handle. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -15 lines)			Patch
M	runtime/vm/dart_api_impl_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View		1 chunk	+7 lines, -9 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM with comment http://codereview.chromium.org/11231015/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/11231015/diff/1/runtime/vm/parser.cc#newcode2285 runtime/vm/parser.cc:2285: const String& function_name = String::Handle(func.name()); This ...

8 years, 2 months ago (2012-10-19 21:43:25 UTC) #2

Tom Ball

8 years, 2 months ago (2012-10-19 22:06:41 UTC) #3

http://codereview.chromium.org/11231015/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/11231015/diff/1/runtime/vm/parser.cc#newcode2285
runtime/vm/parser.cc:2285: const String& function_name =
String::Handle(func.name());
On 2012/10/19 21:43:25, hausner wrote:
> This needs to be a ZoneHandle I think.

Done.

Expand Messages | Collapse Messages

Issue 11231015: Fixed failing 4_External_Functions_A01_t01 test, updated co19-runtime.status with triaged test bug … (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use ZoneHandle for function name, instead of Handle. #

Messages