Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: runtime/vm/parser.cc

Issue 11231015: Fixed failing 4_External_Functions_A01_t01 test, updated co19-runtime.status with triaged test bug … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use ZoneHandle for function name, instead of Handle. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 29e6c29055a81dfd5df00063ec3cb8cc6484a3ef..5f16e5c57ce908afa8f58b43c6900d05857b902e 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -2282,11 +2282,9 @@ SequenceNode* Parser::ParseFunc(const Function& func,
ParseNativeFunctionBlock(&params, func);
} else if (func.is_external()) {
// Body of an external method contains a single throw.
+ const String& function_name = String::ZoneHandle(func.name());
current_block_->statements->Add(
- new ThrowNode(TokenPos(),
- new LiteralNode(TokenPos(),
- String::ZoneHandle(
- Symbols::New("External implementation missing."))), NULL));
+ ThrowNoSuchMethodError(TokenPos(), function_name));
} else {
UnexpectedToken();
}
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698