Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 11230051: Do *not* make file handles inheritable on Windows. (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do *not* make file handles inheritable on Windows. This is the cause of the pub failures to unpack a file that has just been created. The problem is that another 7-zip process has inherited the file handle for a file that we are still writing. When we are done writing the file, we cannot use it because the other process still keeps the handle. R=sgjesse@google.com,rnystrom@google.com BUG=dartbug.com/5910 Committed: https://code.google.com/p/dart/source/detail?r=13960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M runtime/bin/file_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/pub/io.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 2 months ago (2012-10-23 12:59:09 UTC) #1
Søren Gjesse
STV!
8 years, 2 months ago (2012-10-23 13:01:17 UTC) #2
Bob Nystrom
8 years, 2 months ago (2012-10-23 14:06:05 UTC) #3
Wow, fantastic detective work! Thank you thank you thank you!

Powered by Google App Engine
This is Rietveld 408576698