Issue 11226003: Make sure that parts of a date are returned as ints.

Issue 11226003: Make sure that parts of a date are returned as ints. (Closed)

Created:
8 years, 2 months ago by karlklose

Modified:
8 years, 1 month ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure that parts of a date are returned as ints. Firefox may return -0.0 instead of 0 for hours, minutes and seconds, but our toString implementation for dates assumes that these are ints. BUG=http://code.google.com/p/dart/issues/detail?id=6071 Committed: https://code.google.com/p/dart/source/detail?r=13817

Patch Set 1 #

Patch Set 2 : Use '+ 0' instead of '| 0'. #

Patch Set 3 : Add comment. #

Total comments: 4

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -20 lines)			Patch
M	lib/compiler/implementation/lib/js_helper.dart	View	1	1 chunk	+16 lines, -16 lines	4 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11226003/diff/3001/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): https://codereview.chromium.org/11226003/diff/3001/lib/compiler/implementation/lib/js_helper.dart#newcode542 lib/compiler/implementation/lib/js_helper.dart:542: ? JS('int', r'(#.getUTCFullYear() + 0)', lazyAsJsDate(receiver)) Is this ...

8 years, 2 months ago (2012-10-19 11:23:41 UTC) #3

kasperl

LGTM. https://codereview.chromium.org/11226003/diff/3001/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): https://codereview.chromium.org/11226003/diff/3001/lib/compiler/implementation/lib/js_helper.dart#newcode542 lib/compiler/implementation/lib/js_helper.dart:542: ? JS('int', r'(#.getUTCFullYear() + 0)', lazyAsJsDate(receiver)) I prefer ...

8 years, 2 months ago (2012-10-19 11:26:26 UTC) #4

ngeoffray

https://codereview.chromium.org/11226003/diff/3001/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): https://codereview.chromium.org/11226003/diff/3001/lib/compiler/implementation/lib/js_helper.dart#newcode542 lib/compiler/implementation/lib/js_helper.dart:542: ? JS('int', r'(#.getUTCFullYear() + 0)', lazyAsJsDate(receiver)) This looks very ...

8 years, 1 month ago (2012-10-25 15:14:33 UTC) #5

ngeoffray

8 years, 1 month ago (2012-10-26 11:42:44 UTC) #6

http://codereview.chromium.org/11226003/diff/3001/lib/compiler/implementation...
File lib/compiler/implementation/lib/js_helper.dart (right):

http://codereview.chromium.org/11226003/diff/3001/lib/compiler/implementation...
lib/compiler/implementation/lib/js_helper.dart:542: ? JS('int',
r'(#.getUTCFullYear() + 0)', lazyAsJsDate(receiver))
On 2012/10/25 15:14:33, ngeoffray wrote:
> This looks very magic. A comment or helper would be great.

Scratch that comment, I just saw: https://codereview.chromium.org/11189124/

Expand Messages | Collapse Messages