Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 11226003: Make sure that parts of a date are returned as ints. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add comment. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index 98a7c72ccf61d68f50a04916fd76a659f32ff031..d8cda34819f032deac654b695f644fdd9f52c831 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -2157,7 +2157,7 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
js.Expression left = pop();
use(input);
js.Expression right = pop();
- // TODO(4984): Deal with infinity.
+ // TODO(4984): Deal with infinity and -0.0.
push(new js.LiteralExpression.withData('Math.floor(#) === #',
<js.Expression>[left, right]));
}

Powered by Google App Engine
This is Rietveld 408576698