Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1121303002: VM: Improve unoptimized code size by avoid emitting field guards. (Closed)

Created:
5 years, 7 months ago by Florian Schneider
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Improve unoptimized code size by avoid emitting field guards. Avoid emitting field guard code for fields that have dynamic cid and/or no fixed length. To keep unoptimized and optimized flow-graphs in sync, the deopt-id counter has to be advanced accordingly if the guard instructions are not emitted. If optimizations are disabled via --noopt, do not emit any field guards and edge counters. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45502

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -53 lines) Patch
M runtime/vm/flow_graph_builder.cc View 2 chunks +25 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 7 months ago (2015-05-04 18:35:27 UTC) #2
Vyacheslav Egorov (Google)
lgtm
5 years, 7 months ago (2015-05-04 18:45:26 UTC) #3
Florian Schneider
5 years, 7 months ago (2015-05-04 18:46:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r45502 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698