Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 1121303002: VM: Improve unoptimized code size by avoid emitting field guards. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 45494)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -1425,10 +1425,7 @@
const intptr_t field_cid = field().guarded_cid();
const intptr_t nullability = field().is_nullable() ? kNullCid : kIllegalCid;
- if (field_cid == kDynamicCid) {
- ASSERT(!compiler->is_optimizing());
- return; // Nothing to emit.
- }
+ ASSERT(field_cid != kDynamicCid);
const bool emit_full_guard =
!compiler->is_optimizing() || (field_cid == kIllegalCid);
@@ -1580,10 +1577,7 @@
void GuardFieldLengthInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- if (field().guarded_list_length() == Field::kNoFixedLength) {
- ASSERT(!compiler->is_optimizing());
- return; // Nothing to emit.
- }
+ ASSERT(field().guarded_list_length() != Field::kNoFixedLength);
Label* deopt = compiler->is_optimizing() ?
compiler->AddDeoptStub(deopt_id(), ICData::kDeoptGuardField) : NULL;
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698