Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1120633002: Refactor index operator in SimpleTypeInferrer. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor index operator in SimpleTypeInferrer. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45683

Patch Set 1 #

Patch Set 2 : Fix bug. #

Total comments: 6

Patch Set 3 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+918 lines, -210 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +254 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 12 chunks +144 lines, -85 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 2 11 chunks +182 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 1 chunk +15 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 2 10 chunks +74 lines, -30 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 8 chunks +188 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-04-30 14:27:46 UTC) #2
karlklose
On 2015/04/30 14:27:46, Johnni Winther wrote: LGTM.
5 years, 7 months ago (2015-05-11 10:38:37 UTC) #3
karlklose
https://codereview.chromium.org/1120633002/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1120633002/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode1714 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1714: ir.Primitive handleSuperUnresolvedGetterIndexPostfixPrefix( How about 'handle*Unresolved**Super*GetterIndexPostfixPrefix'? (also below?) https://codereview.chromium.org/1120633002/diff/20001/pkg/compiler/lib/src/resolution/access_semantics.dart File ...
5 years, 7 months ago (2015-05-11 10:38:56 UTC) #4
Johnni Winther
https://codereview.chromium.org/1120633002/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1120633002/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode1714 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1714: ir.Primitive handleSuperUnresolvedGetterIndexPostfixPrefix( On 2015/05/11 10:38:55, karlklose wrote: > How ...
5 years, 7 months ago (2015-05-11 13:04:29 UTC) #5
Johnni Winther
5 years, 7 months ago (2015-05-11 13:15:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45683 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698