Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1120633002: Refactor index operator in SimpleTypeInferrer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix bug. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.ir_builder_task; 5 library dart2js.ir_builder_task;
6 6
7 import '../closure.dart' as closurelib; 7 import '../closure.dart' as closurelib;
8 import '../closure.dart' hide ClosureScope; 8 import '../closure.dart' hide ClosureScope;
9 import '../constants/expressions.dart'; 9 import '../constants/expressions.dart';
10 import '../dart_types.dart'; 10 import '../dart_types.dart';
(...skipping 1693 matching lines...) Expand 10 before | Expand all | Expand 10 after
1704 return irBuilder.buildSuperIndex(indexFunction, indexValue); 1704 return irBuilder.buildSuperIndex(indexFunction, indexValue);
1705 }, 1705 },
1706 operator: operator, 1706 operator: operator,
1707 setValue: (ir.Primitive result) { 1707 setValue: (ir.Primitive result) {
1708 irBuilder.buildSuperIndexSet(indexSetFunction, indexValue, result); 1708 irBuilder.buildSuperIndexSet(indexSetFunction, indexValue, result);
1709 }, 1709 },
1710 isPrefix: isPrefix); 1710 isPrefix: isPrefix);
1711 } 1711 }
1712 1712
1713 @override 1713 @override
1714 ir.Primitive handleSuperUnresolvedGetterIndexPostfixPrefix(
karlklose 2015/05/11 10:38:55 How about 'handle*Unresolved**Super*GetterIndexPos
Johnni Winther 2015/05/11 13:04:28 Done.
1715 ast.Send node,
1716 Element element,
1717 ast.Node index,
1718 op.IncDecOperator operator,
1719 arg,
1720 {bool isPrefix}) {
1721 return giveup(node, 'handleSuperUnresolvedGetterIndexPostfixPrefix');
1722 }
1723
1724 @override
1725 ir.Primitive handleSuperUnresolvedSetterIndexPostfixPrefix(
1726 ast.Send node,
1727 FunctionElement indexFunction,
1728 Element element,
1729 ast.Node index,
1730 op.IncDecOperator operator,
1731 arg,
1732 {bool isPrefix}) {
1733 return giveup(node, 'handleSuperUnresolvedGetterIndexPostfixPrefix');
1734 }
1735
1736 @override
1737 ir.Primitive visitUnresolvedSuperGetterCompoundIndexSet(
1738 ast.Send node,
1739 Element element,
1740 ast.Node index,
1741 op.AssignmentOperator operator,
1742 ast.Node rhs,
1743 arg) {
1744 return giveup(node, 'visitUnresolvedSuperGetterCompoundIndexSet');
1745 }
1746
1747 @override
1748 ir.Primitive visitUnresolvedSuperIndexSet(
1749 ast.Send node,
1750 Element element,
1751 ast.Node index,
1752 ast.Node rhs,
1753 arg) {
1754 return giveup(node, 'visitUnresolvedSuperIndexSet');
1755 }
1756
1757 @override
1758 ir.Primitive visitUnresolvedSuperSetterCompoundIndexSet(
1759 ast.Send node,
1760 MethodElement getter,
1761 Element element,
1762 ast.Node index,
1763 op.AssignmentOperator operator,
1764 ast.Node rhs,
1765 arg) {
1766 return giveup(node, 'visitUnresolvedSuperSetterCompoundIndexSet');
1767 }
1768
1769 @override
1714 ir.Primitive handleStaticSetterSet( 1770 ir.Primitive handleStaticSetterSet(
1715 ast.SendSet node, 1771 ast.SendSet node,
1716 FunctionElement setter, 1772 FunctionElement setter,
1717 ast.Node rhs, 1773 ast.Node rhs,
1718 _) { 1774 _) {
1719 return irBuilder.buildStaticSetterSet(setter, visit(rhs)); 1775 return irBuilder.buildStaticSetterSet(setter, visit(rhs));
1720 } 1776 }
1721 1777
1722 @override 1778 @override
1723 ir.Primitive visitSuperFieldCompound( 1779 ir.Primitive visitSuperFieldCompound(
(...skipping 1182 matching lines...) Expand 10 before | Expand all | Expand 10 after
2906 node.body = replacementFor(node.body); 2962 node.body = replacementFor(node.body);
2907 } 2963 }
2908 } 2964 }
2909 2965
2910 /// Visit a just-deleted subterm and unlink all [Reference]s in it. 2966 /// Visit a just-deleted subterm and unlink all [Reference]s in it.
2911 class RemovalVisitor extends ir.RecursiveVisitor { 2967 class RemovalVisitor extends ir.RecursiveVisitor {
2912 processReference(ir.Reference reference) { 2968 processReference(ir.Reference reference) {
2913 reference.unlink(); 2969 reference.unlink();
2914 } 2970 }
2915 } 2971 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698