Issue 11195042: Disable hoisting of checked-mode assertions out of loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11195042: Disable hoisting of checked-mode assertions out of loops. (Closed)

Created:
8 years, 2 months ago by Florian Schneider

Modified:
8 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disable hoisting of checked-mode assertions out of loops. They can only be safely hoisted if the loop is always executed at least once. For now, I added a TODO to add an analysis for safely hoisting these asserts. TEST=tests/language/optimized_hoisting_checked_mode_assert.dart Committed: https://code.google.com/p/dart/source/detail?r=13791

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
	A	tests/language/optimized_hoisting_checked_mode_assert.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages