runtime/vm/flow_graph_optimizer.cc - Issue 11195042: Disable hoisting of checked-mode assertions out of loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11195042: Disable hoisting of checked-mode assertions out of loops. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 13776)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -2335,7 +2335,11 @@

break;

}

- if (inputs_loop_invariant) {

+ if (inputs_loop_invariant &&

+ !current->IsAssertAssignable() &&

+ !current->IsAssertBoolean()) {

+ // TODO(fschneider): Enable hoisting of Assert-instructions

+ // if it safe to do.

Hoist(&it, pre_header, current);

} else if (current->IsCheckSmi() &&

current->InputAt(0)->definition()->IsPhi()) {

« no previous file with comments | « no previous file | tests/language/optimized_hoisting_checked_mode_assert.dart » ('j') | no next file with comments »