Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11191078: Make hashCode a getter and not a method. (Closed)

Created:
8 years, 2 months ago by floitsch
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org, Mads Ager (google)
Visibility:
Public.

Description

Make hashCode a getter and not a method. Committed: https://code.google.com/p/dart/source/detail?r=13866

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update status file #

Patch Set 4 : Don't change the testing-framework yet. #

Patch Set 5 : Update status file with co19 issue number. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -199 lines) Patch
M lib/compiler/implementation/constants.dart View 1 15 chunks +51 lines, -42 lines 0 comments Download
M lib/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/js_backend/namer.dart View 1 2 chunks +11 lines, -0 lines 0 comments Download
M lib/compiler/implementation/js_backend/native_emitter.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M lib/compiler/implementation/lib/isolate_patch.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/scanner/byte_strings.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/keyword.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/string_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/token.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/value_set.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/tree/nodes.dart View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M lib/compiler/implementation/typechecker.dart View 1 2 3 6 chunks +10 lines, -10 lines 0 comments Download
M lib/compiler/implementation/types/concrete_types_inferrer.dart View 6 chunks +10 lines, -10 lines 0 comments Download
M lib/compiler/implementation/universe/universe.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/duration.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/core/hashable.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/date.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/hash_map_set.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/isolate/base.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/fixnum/int32.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fixnum/int64.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fixnum/intx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/logging/lib/logging.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/http_impl.dart View 4 chunks +4 lines, -6 lines 0 comments Download
M runtime/bin/path_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket.dart View 1 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/socket_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/websocket.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/websocket_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/double.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/integers.dart View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/object_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/string.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/string_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 4 1 chunk +19 lines, -0 lines 1 comment Download
M tests/co19/co19-runtime.status View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/hash_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/big_integer_vm_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/date_time2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/null_test.dart View 1 2 chunks +1 line, -3 lines 0 comments Download
M tests/corelib/set_iterator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/port_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/arithmetic_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/hash_code_mangling_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/savannah_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/io/http_server_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/medium_integer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/pub/package.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M utils/pub/version.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/yaml/model.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M utils/pub/yaml/yaml_map.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
I will create a co19 bug and update the status files before submitting.
8 years, 2 months ago (2012-10-19 17:12:41 UTC) #1
Lasse Reichstein Nielsen
LGTM
8 years, 2 months ago (2012-10-20 11:35:46 UTC) #2
Mads Ager (google)
LGTM I'm a little bit paranoid when it comes to changes to the intrinsifier (I ...
8 years, 2 months ago (2012-10-22 08:16:27 UTC) #3
ahe
8 years, 2 months ago (2012-10-22 13:55:08 UTC) #4 
https://codereview.chromium.org/11191078/diff/7068/tests/co19/co19-dart2js.st...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/11191078/diff/7068/tests/co19/co19-dart2js.st...
tests/co19/co19-dart2js.status:262: # co19 issue 273
When I have to update co19 status files, these kinds of comments take longer
time. It would really help me a lot if you could avoid using section comments
and instead annotate each line with the co19 issue number. For example, see
lines 378-457.

Powered by Google App Engine
This is Rietveld 408576698