Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 11191078: Make hashCode a getter and not a method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 1dcd138460433c6ebdad28e2657b4bdd5bf1f3ed..5ba15e5b44885e396e7e381fcd39f66262f2fce0 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -465,7 +465,7 @@ class HBasicBlock extends HInstructionList {
dominatedBlocks = <HBasicBlock>[],
bailoutTargets = <HBailoutTarget>[];
- int hashCode() => id;
+ int get hashCode => id;
bool isNew() => status == STATUS_NEW;
bool isOpen() => status == STATUS_OPEN;
@@ -816,7 +816,7 @@ abstract class HInstruction implements Spannable {
: id = idCounter++,
usedBy = <HInstruction>[];
- int hashCode() => id;
+ int get hashCode => id;
bool getFlag(int position) => (flags & (1 << position)) != 0;
void setFlag(int position) { flags |= (1 << position); }
@@ -2421,7 +2421,7 @@ class HStatic extends HInstruction {
toString() => 'static ${element.name}';
accept(HVisitor visitor) => visitor.visitStatic(this);
- int gvnHashCode() => super.gvnHashCode() ^ element.hashCode();
+ int gvnHashCode() => super.gvnHashCode() ^ element.hashCode;
int typeCode() => HInstruction.STATIC_TYPECODE;
bool typeEquals(other) => other is HStatic;
bool dataEquals(HStatic other) => element == other.element;

Powered by Google App Engine
This is Rietveld 408576698