Issue 5530. Make DartParser thread safe. Remove compiler lock.

Issue 5530. Make DartParser thread safe. Remove compiler lock.
http://code.google.com/p/dart/issues/detail?id=5530


R=danrubel@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=14103

[danrubel, 2012-10-24 09:56:48]

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java
(right):

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:774:
return DartCompiler.analyzeLibraries(
Keep synchronization for now (see below).

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:777:
config,
nit: fix indentation

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:834:
Map<URI, LibraryUnit> libMap = DartCompiler.analyzeLibraries(
Keep synchronization for now (see below).

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:857:
DartCompiler.compileLib(libSource, embeddedLibraries, config, provider,
listener);
This method is called by DartCompilerWarmup#warmupCompiler, which passes a root
artifact provider singleton. warmupCompiler must complete before any other calls
that use the singleton otherwise the results will be unpredictable. I recommend
keeping the synchronization around the methods involving DartArtifactProvider
for now to simplify this CL and address that issue in a subsequent CL.

[scheglov, 2012-10-25 18:54:42]

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java
(right):

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:777:
config,
On 2012/10/24 09:56:48, danrubel wrote:
> nit: fix indentation

I don't see it in my source.
May be already fixed.

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:857:
DartCompiler.compileLib(libSource, embeddedLibraries, config, provider,
listener);
On 2012/10/24 09:56:48, danrubel wrote:
> This method is called by DartCompilerWarmup#warmupCompiler, which passes a
root
> artifact provider singleton. warmupCompiler must complete before any other
calls
> that use the singleton otherwise the results will be unpredictable. I
recommend
> keeping the synchronization around the methods involving DartArtifactProvider
> for now to simplify this CL and address that issue in a subsequent CL.

I think we can try alternative for lock - use latch to wait for warm up.

[danrubel, 2012-10-25 20:21:49]

LGTM

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java
(right):

https://codereview.chromium.org/11189149/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:857:
DartCompiler.compileLib(libSource, embeddedLibraries, config, provider,
listener);
On 2012/10/25 18:54:42, scheglov wrote:
> On 2012/10/24 09:56:48, danrubel wrote:
> > This method is called by DartCompilerWarmup#warmupCompiler, which passes a
> root
> > artifact provider singleton. warmupCompiler must complete before any other
> calls
> > that use the singleton otherwise the results will be unpredictable. I
> recommend
> > keeping the synchronization around the methods involving
DartArtifactProvider
> > for now to simplify this CL and address that issue in a subsequent CL.
> 
> I think we can try alternative for lock - use latch to wait for warm up.

I like it !