editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java - Issue 11189149: Issue 5530. Make DartParser thread safe. Remove compiler lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java

Issue 11189149: Issue 5530. Make DartParser thread safe. Remove compiler lock. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Wait for warm up before allowing other thread for use DartCompilerUtilities Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java

index 06cc1748b1a3b29a4e60b3cc2c5ab9414d020940..0f04574512311b28d76b382ab8d20e2a7994b39a 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java

@@ -20,8 +20,8 @@ import com.google.dart.compiler.DartCompilerListener;

import com.google.dart.compiler.DartSource;

import com.google.dart.compiler.DefaultCompilerConfiguration;

import com.google.dart.compiler.LibrarySource;

-import com.google.dart.compiler.Source;

import com.google.dart.compiler.PackageLibraryManager;

+import com.google.dart.compiler.Source;

import com.google.dart.compiler.UrlLibrarySource;

import com.google.dart.compiler.UrlSource;

import com.google.dart.compiler.metrics.CompilerMetrics;

@@ -211,9 +211,12 @@ public class DartCompilerWarmup {

return metrics;

}

};

+ DartCompilerUtilities.warmUpStart();

DartCompilerUtilities.secureCompileLib(libSrc, config, provider, listener);

- } catch (IOException e) {

+ } catch (Exception e) {

DartCore.logError(e);

+ } finally {

+ DartCompilerUtilities.warmUpDone();

}

if (DartCoreDebug.WARMUP) {

ByteArrayOutputStream out = new ByteArrayOutputStream(400);