Issue 11175054: Change Directory.create to not fail on existing directory with that name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11175054: Change Directory.create to not fail on existing directory with that name. (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)

Modified:
8 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change Directory.create to not fail on existing directory with that name. The new semantics is to ensure that a directory with that name exists. There is no way to reliably guard a create call against existing directories in an async program. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13933

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -5 lines)			Patch
M	runtime/bin/directory.dart	View	1	1 chunk	+8 lines, -5 lines	0 comments	Download
M	runtime/bin/directory_linux.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/directory_macos.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/standalone/io/directory_test.dart	View		3 chunks	+82 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/11175054/diff/1/runtime/bin/directory.dart File runtime/bin/directory.dart (right): https://codereview.chromium.org/11175054/diff/1/runtime/bin/directory.dart#newcode43 runtime/bin/directory.dart:43: * completes with this directory once it has ...

8 years, 2 months ago (2012-10-23 09:08:07 UTC) #2

Mads Ager (google)

8 years, 2 months ago (2012-10-23 09:14:44 UTC) #3

https://codereview.chromium.org/11175054/diff/1/runtime/bin/directory.dart
File runtime/bin/directory.dart (right):

https://codereview.chromium.org/11175054/diff/1/runtime/bin/directory.dart#ne...
runtime/bin/directory.dart:43: * completes with this directory once it has been
created.
On 2012/10/23 09:08:07, Søren Gjesse wrote:
> Exception information here as well as for the sync version below?

Done.

Expand Messages | Collapse Messages