Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Side by Side Diff: runtime/bin/directory_macos.cc

Issue 11175054: Change Directory.create to not fail on existing directory with that name. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/directory_linux.cc ('k') | runtime/bin/directory_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/directory.h" 5 #include "bin/directory.h"
6 6
7 #include <dirent.h> 7 #include <dirent.h>
8 #include <errno.h> 8 #include <errno.h>
9 #include <sys/param.h> 9 #include <sys/param.h>
10 #include <sys/stat.h> 10 #include <sys/stat.h>
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 } 374 }
375 } 375 }
376 376
377 377
378 char* Directory::Current() { 378 char* Directory::Current() {
379 return getcwd(NULL, 0); 379 return getcwd(NULL, 0);
380 } 380 }
381 381
382 382
383 bool Directory::Create(const char* dir_name) { 383 bool Directory::Create(const char* dir_name) {
384 // If the directory already exists and is a directory do not
385 // attempt to create it again and treat it as a success.
386 if (Exists(dir_name) == EXISTS) return true;
384 // Create the directory with the permissions specified by the 387 // Create the directory with the permissions specified by the
385 // process umask. 388 // process umask.
386 return (TEMP_FAILURE_RETRY(mkdir(dir_name, 0777)) == 0); 389 return (TEMP_FAILURE_RETRY(mkdir(dir_name, 0777)) == 0);
387 } 390 }
388 391
389 392
390 char* Directory::CreateTemp(const char* const_template) { 393 char* Directory::CreateTemp(const char* const_template) {
391 // Returns a new, unused directory name, modifying the contents of 394 // Returns a new, unused directory name, modifying the contents of
392 // dir_template. Creates the directory with the permissions specified 395 // dir_template. Creates the directory with the permissions specified
393 // by the process umask. 396 // by the process umask.
(...skipping 29 matching lines...) Expand all
423 return DeleteRecursively(dir_name); 426 return DeleteRecursively(dir_name);
424 } 427 }
425 } 428 }
426 429
427 430
428 bool Directory::Rename(const char* path, const char* new_path) { 431 bool Directory::Rename(const char* path, const char* new_path) {
429 ExistsResult exists = Exists(path); 432 ExistsResult exists = Exists(path);
430 if (exists != EXISTS) return false; 433 if (exists != EXISTS) return false;
431 return (TEMP_FAILURE_RETRY(rename(path, new_path)) == 0); 434 return (TEMP_FAILURE_RETRY(rename(path, new_path)) == 0);
432 } 435 }
OLDNEW
« no previous file with comments | « runtime/bin/directory_linux.cc ('k') | runtime/bin/directory_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698