Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1113063005: improve import suggestion (Closed)

Created:
5 years, 7 months ago by danrubel
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

improve import suggestion BUG=dartbug.com/19941 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45497

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 4 chunks +19 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 2 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 7 months ago (2015-05-01 14:56:26 UTC) #2
scheglov
lgtm
5 years, 7 months ago (2015-05-01 15:08:14 UTC) #3
danrubel
5 years, 7 months ago (2015-05-04 18:02:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698