Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: pkg/analysis_server/test/services/completion/keyword_contributor_test.dart

Issue 1113063005: improve import suggestion (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/domain_completion_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/keyword_contributor_test.dart b/pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
index 5f97c4f50ebc32df9dccced0026e2e2d6a39b15e..46940bf2c9ebab489990cb0926d07079d237fcef 100644
--- a/pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
@@ -179,10 +179,17 @@ class KeywordContributorTest extends AbstractCompletionTest {
Set<String> actualCompletions = new Set<String>();
expectedCompletions.addAll(expectedKeywords.map((k) => k.syntax));
expectedCompletions.addAll(pseudoKeywords);
+ if (expectedCompletions.contains(Keyword.IMPORT.syntax)) {
+ expectedCompletions.remove(Keyword.IMPORT.syntax);
+ expectedCompletions.add("import '';");
+ expectedCompletions.add("import '' as ;");
+ expectedCompletions.add("import '' hide ;");
+ expectedCompletions.add("import '' show ;");
+ }
for (CompletionSuggestion s in request.suggestions) {
if (s.kind == CompletionSuggestionKind.KEYWORD) {
Keyword k = Keyword.keywords[s.completion];
- if (k == null && !pseudoKeywords.contains(s.completion)) {
+ if (k == null && !expectedCompletions.contains(s.completion)) {
fail('Invalid keyword suggested: ${s.completion}');
} else {
if (!actualCompletions.add(s.completion)) {
@@ -201,8 +208,18 @@ class KeywordContributorTest extends AbstractCompletionTest {
}
for (CompletionSuggestion s in request.suggestions) {
if (s.kind == CompletionSuggestionKind.KEYWORD) {
- expect(s.relevance, equals(relevance), reason: s.completion);
- expect(s.selectionOffset, equals(s.completion.length));
+ if (s.completion.startsWith(Keyword.IMPORT.syntax)) {
+ int importRelevance = relevance;
+ if (importRelevance == DART_RELEVANCE_HIGH &&
+ s.completion == "import '';") {
+ ++importRelevance;
+ }
+ expect(s.relevance, equals(importRelevance), reason: s.completion);
+ expect(s.selectionOffset, equals(Keyword.IMPORT.syntax.length + 2));
+ } else {
+ expect(s.relevance, equals(relevance), reason: s.completion);
+ expect(s.selectionOffset, equals(s.completion.length));
+ }
expect(s.selectionLength, equals(0));
expect(s.isDeprecated, equals(false));
expect(s.isPotential, equals(false));
« no previous file with comments | « pkg/analysis_server/test/domain_completion_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698