Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 11125005: Support for type dynamic in VM (Closed)

Created:
8 years, 2 months ago by hausner
Modified:
8 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support for type dynamic in VM Old name Dynamic is supported, and automatically converted to lower-case dynamic when parsed. VM flag --warn_legacy_dynamic prints warnings when Dynamic is found. Committed: https://code.google.com/p/dart/source/detail?r=13637

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -118 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/class_finalizer.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 6 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/object.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/parser.cc View 1 13 chunks +25 lines, -11 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +1 line, -2 lines 0 comments Download
M tests/corelib/null_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/black_listed_test.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/cast2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/cast_test.dart View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language/closure_type_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/dynamic_test.dart View 1 2 3 chunks +19 lines, -19 lines 0 comments Download
M tests/language/factory2_negative_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/factory_redirection_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/generic_instanceof2_test.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/generic_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/generics2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/import_core_prefix_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/instanceof3_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/prefix16_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/pseudo_kw_illegal_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/pseudo_kw_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/setter3_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/type_cast_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/type_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
It's actually a small change, mostly changes in comments.
8 years, 2 months ago (2012-10-12 20:05:25 UTC) #1
regis
LGTM, but since dart2js already supports dynamic, why not fix all the language tests as ...
8 years, 2 months ago (2012-10-12 20:52:12 UTC) #2
hausner
8 years, 2 months ago (2012-10-12 21:58:58 UTC) #3
Done. Will do another round of testing before checkin. Thank you.

Powered by Google App Engine
This is Rietveld 408576698