Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: runtime/vm/object.cc

Issue 11125005: Support for type dynamic in VM (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 13630)
+++ runtime/vm/object.cc (working copy)
@@ -882,7 +882,7 @@
type = Type::NewNonParameterizedType(cls);
object_store->set_void_type(type);
- // The class 'Dynamic' is registered in the class dictionary because its name
+ // The class 'dynamic' is registered in the class dictionary because its name
// is a built-in identifier, rather than a reserved keyword. Its name is not
// heap allocated, because the class resides in the VM isolate.
// The corresponding type, the "unknown type", is stored in the object store.
@@ -2010,7 +2010,7 @@
Error* malformed_error) const {
ASSERT(!IsVoidClass());
// Check for DynamicType.
- // Each occurrence of DynamicType in type T is interpreted as the Dynamic
+ // Each occurrence of DynamicType in type T is interpreted as the dynamic
// type, a supertype of all types.
if (other.IsDynamicClass()) {
return true;
@@ -2588,7 +2588,7 @@
ASSERT(!type.IsNull());
if (!type.HasResolvedTypeClass()) {
if (raw_instantiated && type.IsTypeParameter()) {
- // An uninstantiated type parameter is equivalent to Dynamic.
+ // An uninstantiated type parameter is equivalent to dynamic.
continue;
}
ASSERT((!raw_instantiated && type.IsTypeParameter()) ||
@@ -8045,12 +8045,12 @@
if (other.IsVoidType()) {
return true;
}
- // Otherwise, null is only an instance of Object and of Dynamic.
+ // Otherwise, null is only an instance of Object and of dynamic.
// It is not necessary to fully instantiate the other type for this test.
Class& other_class = Class::Handle();
if (other.IsTypeParameter()) {
if (other_instantiator.IsNull()) {
- return true; // Other type is uninstantiated, i.e. Dynamic.
+ return true; // Other type is uninstantiated, i.e. dynamic.
}
const TypeParameter& other_type_param = TypeParameter::Cast(other);
const AbstractType& instantiated_other = AbstractType::Handle(
@@ -8091,7 +8091,7 @@
// allocation of a new AbstractType by inlining the code.
if (other.IsTypeParameter()) {
if (other_instantiator.IsNull()) {
- // An uninstantiated type parameter is equivalent to Dynamic.
+ // An uninstantiated type parameter is equivalent to dynamic.
return true;
}
const TypeParameter& other_type_param = TypeParameter::Cast(other);
@@ -8321,12 +8321,12 @@
if (num_type_params > num_args) {
first_type_param_index = 0;
if (!IsFinalized() || IsBeingFinalized() || IsMalformed()) {
- // Most probably a malformed type. Do not fill up with "Dynamic",
+ // Most probably a malformed type. Do not fill up with "dynamic",
// but use actual vector.
num_type_params = num_args;
} else {
ASSERT(num_args == 0); // Type is raw.
- // No need to fill up with "Dynamic".
+ // No need to fill up with "dynamic".
num_type_params = 0;
}
} else {
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698