cps-ir: Implement type tests for interface types without type arguments.

cps-ir: Implement type tests for interface types without type arguments.

R=sigurdm@google.com, kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45484

[karlklose, 2015-04-28 11:21:17]

Patchset #2 (id:10001) has been deleted

[sigurdm, 2015-04-30 09:30:51]

sigurdm@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2015-04-30 09:30:51]

LGTM

https://codereview.chromium.org/1110813005/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/1110813005/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:396: ?
emitNativeSubtypeTest(node, value, type.element)
Maybe it would be nicer to have the logic checking for primitiveness inside a
method TypeTestEmitter.emitSubTypeTest, and that would be able to call out to
either emitNativeSubtypeTest or emitGeneralSubtypeTest.

https://codereview.chromium.org/1110813005/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/codegen/glue.dart (right):

https://codereview.chromium.org/1110813005/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/codegen/glue.dart:23: CodegenEnqueuer get
enqueuer => _compiler.enqueuer.codegen;
Make private?

https://codereview.chromium.org/1110813005/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/codegen/glue.dart:187: bool
isNativePrimitiveType(DartType type) {
This seems to complex to belong in glue.
Could it be replaced by hasDirectCheckFor from js_backend/backend.dart or maybe
put it there, and here just make a redirection?

[karlklose, 2015-05-04 07:58:53]

Committed patchset #3 (id:40001) manually as 45484 (presubmit successful).