cps-ir: Implement type tests for interface types without type arguments.

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
 import '../../js/js.dart' as js;
 import '../../elements/elements.dart';
 import '../../io/source_information.dart' show SourceInformation;
 import '../../util/maplet.dart';
 import '../../constants/values.dart';
 import '../../dart2jslib.dart';
+import '../../dart_types.dart';
+
+part 'type_test_emitter.dart';
 
 class CodegenBailout {
   final tree_ir.Node node;
   final String reason;
   CodegenBailout(this.node, this.reason);
   String get message {
     return 'bailout${node != null ? " on $node" : ""}: $reason';
   }
 }
 
 class CodeGenerator extends tree_ir.StatementVisitor
-                    with tree_ir.ExpressionVisitor<js.Expression> {
+                    with tree_ir.ExpressionVisitor<js.Expression>,
+                         TypeTestEmitter {
   final CodegenRegistry registry;
 
   final Glue glue;
 
   ExecutableElement currentFunction;
 
   /// Maps variables to their name.
   Map<tree_ir.Variable, String> variableNames = <tree_ir.Variable, String>{};
 
   /// Maps local constants to their name.
@@ skipping 336 matching lines @@
     return new js.Prefix("!", visitExpression(node.operand));
   }
 
   @override
   js.Expression visitThis(tree_ir.This node) {
     return new js.This();
   }
 
   @override
   js.Expression visitTypeOperator(tree_ir.TypeOperator node) {
-    return giveup(node);
-    // TODO: implement visitTypeOperator
+    if (!node.isTypeTest) {
+      giveup(node, 'type casts not implemented.');
+    }
+    DartType type = node.type;
+    if (type is InterfaceType && type.typeArguments.isEmpty) {
+      glue.registerIsCheck(type, registry);
+      js.Expression value = visitExpression(node.receiver);
+      return glue.isNativePrimitiveType(type)
+          ? emitNativeSubtypeTest(node, value, type.element)

[sigurdm, 2015/04/30 09:30:51]

Maybe it would be nicer to have the logic checking for primitiveness inside a
method TypeTestEmitter.emitSubTypeTest, and that would be able to call out to
either emitNativeSubtypeTest or emitGeneralSubtypeTest.

+          : emitGeneralSubtypeTest(node, value, type);
+    }
+    return giveup(node, 'type check unimplemented for $type.');
   }
 
   @override
   js.Expression visitVariableUse(tree_ir.VariableUse node) {
     return buildVariableAccess(node.variable);
   }
 
   js.Expression buildVariableAccess(tree_ir.Variable variable) {
     return new js.VariableUse(getVariableName(variable));
   }
@@ skipping 254 matching lines @@
 
   @override
   visitVariableDeclaration(tree_ir.VariableDeclaration node) {
     return errorUnsupportedNode(node);
   }
 
   errorUnsupportedNode(tree_ir.DartSpecificNode node) {
     throw "Unsupported node in JS backend: $node";
   }
 }