Issue 11094017: 1. Add isolate id parameter to all the debugger commands in the debugger wire protocol so that the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11094017: 1. Add isolate id parameter to all the debugger commands in the debugger wire protocol so that the … (Closed)

Created:
8 years, 2 months ago by siva

Modified:
8 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, hausner, keertip, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

1. Add isolate id parameter to all the debugger commands in the debugger wire protocol so that the commands are directed to the appropriate isolate. 2. Changed ddbg to pass the isolate ID in the debugger wire message. The Dart debugger protocol document has been changed to reflect this. Committed: https://code.google.com/p/dart/source/detail?r=13691

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -46 lines)			Patch
M	runtime/bin/dbg_connection.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
M	runtime/bin/dbg_message.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tools/ddbg.dart	View	1	4 chunks	+65 lines, -35 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM -ip

Expand Messages | Collapse Messages