Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: runtime/bin/dbg_connection.cc

Issue 11094017: 1. Add isolate id parameter to all the debugger commands in the debugger wire protocol so that the … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/dbg_message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dbg_connection.cc
===================================================================
--- runtime/bin/dbg_connection.cc (revision 13685)
+++ runtime/bin/dbg_connection.cc (working copy)
@@ -224,11 +224,13 @@
int32_t cmd_idx = DbgMsgQueueList::LookupIsolateCommand(r.ValueChars(),
r.ValueLen());
if (cmd_idx != DbgMsgQueueList::kInvalidCommand) {
+ const char* start = msgbuf_->buf();
+ const char* end = r.EndOfObject();
// Get debug message queue corresponding to isolate.
- // TODO(asiva): Once we have support for including the isolate id
- // in the debug wire protocol we need to read the isolate id and
- // pass it down to AddIsolateMessage.
- if (!DbgMsgQueueList::AddIsolateMessage(ILLEGAL_ISOLATE_ID,
+ MessageParser msg_parser(start, (end - start));
+ Dart_IsolateId isolate_id =
+ static_cast<Dart_IsolateId>(msg_parser.GetIntParam("isolateId"));
+ if (!DbgMsgQueueList::AddIsolateMessage(isolate_id,
cmd_idx,
msgbuf_->buf(),
r.EndOfObject(),
« no previous file with comments | « no previous file | runtime/bin/dbg_message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698