Issue 11088038: Fix IEDriver error on closing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11088038: Fix IEDriver error on closing. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
gram

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix IEDriver error on closing. Committed: https://code.google.com/p/dart/source/detail?r=13444

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	tools/testing/run_selenium.py	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gram

I assume that the old try/catch was to handle IE crashing on close()? If so, ...

8 years, 2 months ago (2012-10-09 21:18:09 UTC) #2

Emily Fortuna

8 years, 2 months ago (2012-10-09 21:23:26 UTC) #3

yep. The try catch was to handle the IE crashing and also chrome crashing
because if you look -- the if statement was always evaluating to false since it
was a browser object, not a string (typechecking is nice)

Expand Messages | Collapse Messages