Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/testing/run_selenium.py

Issue 11088038: Fix IEDriver error on closing. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/run_selenium.py
===================================================================
--- tools/testing/run_selenium.py (revision 13260)
+++ tools/testing/run_selenium.py (working copy)
@@ -212,13 +212,10 @@
return
# A timeout exception is thrown if nothing happens within the time limit.
- if browser != 'chrome':
+ if (type(browser) is not selenium.webdriver.chrome.webdriver.WebDriver and
+ type(browser) is not selenium.webdriver.ie.webdriver.WebDriver):
browser.close()
- try:
- browser.quit()
- except selenium.common.exceptions.WebDriverException:
- # TODO(efortuna): Figure out why this crashes.... and avoid?
- pass
+ browser.quit()
def report_results(mode, source):
# TODO(vsm): Add a failure check for Dromaeo.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698