Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1108783003: Refactor SsaBuilder.visitSuperSend. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Anders Johnsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor SsaBuilder.visitSuperSend. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45439

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+711 lines, -148 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 5 chunks +56 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 6 chunks +48 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 16 chunks +163 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 15 chunks +73 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 9 chunks +10 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +206 lines, -32 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 16 chunks +137 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Changes to SemanticSendVisitor driven by the refactoring of SsaBuilder.visitSuperSend.
5 years, 8 months ago (2015-04-27 13:54:38 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1108783003/diff/1/pkg/compiler/lib/src/resolution/send_structure.dart File pkg/compiler/lib/src/resolution/send_structure.dart (right): https://codereview.chromium.org/1108783003/diff/1/pkg/compiler/lib/src/resolution/send_structure.dart#newcode385 pkg/compiler/lib/src/resolution/send_structure.dart:385: // TODO(johnniwinther): Support more variant of this invoke ...
5 years, 8 months ago (2015-04-27 14:01:55 UTC) #3
Johnni Winther
https://codereview.chromium.org/1108783003/diff/1/pkg/compiler/lib/src/resolution/send_structure.dart File pkg/compiler/lib/src/resolution/send_structure.dart (right): https://codereview.chromium.org/1108783003/diff/1/pkg/compiler/lib/src/resolution/send_structure.dart#newcode385 pkg/compiler/lib/src/resolution/send_structure.dart:385: // TODO(johnniwinther): Support more variant of this invoke structure. ...
5 years, 8 months ago (2015-04-28 08:18:28 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-04-28 08:24:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698