Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1108783003: Refactor SsaBuilder.visitSuperSend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/inferrer/inferrer_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index f1e6fbb44af50141d4be27c6f756f96379c62d51..1be4254ad401c4a0c5cad485fa2523f256aaebba 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -795,6 +795,14 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
}
@override
+ ir.Primitive visitUnresolvedSuperGet(
+ ast.Send node,
+ Element element,
+ _) {
+ return giveup(node, 'visitUnresolvedSuperGet');
+ }
+
+ @override
ir.Primitive visitThisGet(ast.Identifier node, _) {
return irBuilder.buildThis();
}
@@ -917,6 +925,16 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
}
@override
+ ir.Primitive visitUnresolvedSuperBinary(
+ ast.Send node,
+ Element element,
+ op.BinaryOperator operator,
+ ast.Node argument,
+ _) {
+ return giveup(node, 'visitUnresolvedSuperBinary');
+ }
+
+ @override
ir.Primitive visitSuperIndex(
ast.Send node,
FunctionElement function,
@@ -926,6 +944,15 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
}
@override
+ ir.Primitive visitUnresolvedSuperIndex(
+ ast.Send node,
+ Element element,
+ ast.Node index,
+ _) {
+ return giveup(node, 'visitUnresolvedSuperIndex');
+ }
+
+ @override
ir.Primitive visitEquals(
ast.Send node,
ast.Node left,
@@ -993,6 +1020,15 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
function, CallStructure.NO_ARGS, const []);
}
+ @override
+ ir.Primitive visitUnresolvedSuperUnary(
+ ast.Send node,
+ op.UnaryOperator operator,
+ Element element,
+ _) {
+ return giveup(node, 'visitUnresolvedSuperUnary');
+ }
+
// TODO(johnniwinther): Handle this in the [IrBuilder] to ensure the correct
// semantic correlation between arguments and invocation.
List<ir.Primitive> translateDynamicArguments(ast.NodeList nodeList,
@@ -1145,6 +1181,26 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
}
@override
+ ir.Primitive visitSuperMethodIncompatibleInvoke(
+ ast.Send node,
+ MethodElement method,
+ ast.NodeList arguments,
+ CallStructure callStructure,
+ _) {
+ return giveup(node, 'visitSuperMethodIncompatibleInvoke');
+ }
+
+ @override
+ ir.Primitive visitUnresolvedSuperInvoke(
+ ast.Send node,
+ MethodElement method,
+ ast.NodeList arguments,
+ Selector selector,
+ _) {
+ return giveup(node, 'visitUnresolvedSuperInvoke');
+ }
+
+ @override
ir.Primitive visitThisInvoke(
ast.Send node,
ast.NodeList arguments,
« no previous file with comments | « no previous file | pkg/compiler/lib/src/inferrer/inferrer_visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698