Escape "\" in regex to unbreak Windows bot.

Escape "\" in regex to unbreak Windows bot.

Committed: https://code.google.com/p/dart/source/detail?r=31295

[Bob Nystrom, 2013-12-19 19:03:12]

TBR.

[Bob Nystrom, 2013-12-19 19:03:28]

Committed patchset #1 manually as r31295 (presubmit successful).

[nweiz, 2013-12-19 19:34:34]

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
File sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart (right):

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart:14: assetsPath
= assetsPath.replaceAll("\\", "\\\\");
We should have a regExpQuote function in utils (with a TODO to remove it when
issue 4706 is fixed).

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart:16: '^Warning:
Pub reserves paths containing "assets" for using assets from '
Use r"" strings for these.

[Bob Nystrom, 2013-12-19 23:31:12]

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
File sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart (right):

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart:14: assetsPath
= assetsPath.replaceAll("\\", "\\\\");
On 2013/12/19 19:34:34, nweiz wrote:
> We should have a regExpQuote function in utils (with a TODO to remove it when
> issue 4706 is fixed).

Since this is already in, I don't think it's worth the effort now. (And we
generally try to avoid needing to quote regex strings at runtime.)

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart:16: '^Warning:
Pub reserves paths containing "assets" for using assets from '
On 2013/12/19 19:34:34, nweiz wrote:
> Use r"" strings for these.

The second line is using interpolation, and I think it's good for the first line
to be consistent.

[nweiz, 2013-12-19 23:36:05]

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
File sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart (right):

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart:14: assetsPath
= assetsPath.replaceAll("\\", "\\\\");
On 2013/12/19 23:31:12, Bob Nystrom wrote:
> On 2013/12/19 19:34:34, nweiz wrote:
> > We should have a regExpQuote function in utils (with a TODO to remove it
when
> > issue 4706 is fixed).
> 
> Since this is already in, I don't think it's worth the effort now.

I'm uncomfortable with the idea of TBRing something and then saying "it's
already in so it's not worth changing". TBRs should undergo just as much code
review as other CLs.

> And we generally try to avoid needing to quote regex strings at runtime.

This doesn't make sense to me. RegExps are useful for validating test output,
building them dynamically can often make tests more readable, and quoting is
necessary when including arbitrary strings in RegExps.

[Bob Nystrom, 2013-12-27 22:53:01]

Revised here: https://codereview.chromium.org/108243003

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
File sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart (right):

https://codereview.chromium.org/110853007/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart:14: assetsPath
= assetsPath.replaceAll("\\", "\\\\");
On 2013/12/19 23:36:05, nweiz wrote:
> On 2013/12/19 23:31:12, Bob Nystrom wrote:
> > On 2013/12/19 19:34:34, nweiz wrote:
> > > We should have a regExpQuote function in utils (with a TODO to remove it
> when
> > > issue 4706 is fixed).
> > 
> > Since this is already in, I don't think it's worth the effort now.
> 
> I'm uncomfortable with the idea of TBRing something and then saying "it's
> already in so it's not worth changing". TBRs should undergo just as much code
> review as other CLs.

Gah, you're exactly right. I apologize.

> 
> > And we generally try to avoid needing to quote regex strings at runtime.
> 
> This doesn't make sense to me. RegExps are useful for validating test output,
> building them dynamically can often make tests more readable, and quoting is
> necessary when including arbitrary strings in RegExps.

Okey dokey.