Issue 108243003: Add quoteRegExp() to utils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108243003: Add quoteRegExp() to utils. (Closed)

Created:
6 years, 12 months ago by Bob Nystrom

Modified:
6 years, 11 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add quoteRegExp() to utils. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31561

Patch Set 1 #

Total comments: 2

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -2 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/utils.dart	View	1 chunk	+17 lines, -0 lines	2 comments	Download
M	sdk/lib/_internal/pub/test/build/warns_on_assets_paths_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/108243003/diff/1/sdk/lib/_internal/pub/lib/src/utils.dart File sdk/lib/_internal/pub/lib/src/utils.dart (right): https://codereview.chromium.org/108243003/diff/1/sdk/lib/_internal/pub/lib/src/utils.dart#newcode220 sdk/lib/_internal/pub/lib/src/utils.dart:220: const _regExpMetacharacters = const [r"\", '"', "'", r"$", ...

6 years, 11 months ago (2014-01-06 23:34:50 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r31561 (presubmit successful).

6 years, 11 months ago (2014-01-07 18:33:14 UTC) #3

Bob Nystrom

6 years, 11 months ago (2014-01-07 18:52:50 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/108243003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/108243003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/utils.dart:220: const _regExpMetacharacters =
const [r"\", '"', "'", r"$", r"^"];
On 2014/01/06 23:34:50, nweiz wrote:
> Unused constant.

Done.

Expand Messages | Collapse Messages