Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1108123002: Enable profiler by default on Android, and reduce profiler sampling rate for An droid, ARM and MIPS. (Closed)

Created:
5 years, 7 months ago by rmacnak
Modified:
5 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Enable profiler by default on Android, and reduce profiler sampling rate for Android, ARM and MIPS. Raspberry Pi 1 B+ (700MHz single-core ARMv6) --profile_period=1000 DeltaBlue(RunTime): 231748.1111111111 us. --profile_period=10000 DeltaBlue(RunTime): 117826.64705882352 us. --profile_period=20000 DeltaBlue(RunTime): 111494.05555555555 us. --profile_period=50000 DeltaBlue(RunTime): 101028.45000000001 us. --profile=false DeltaBlue(RunTime): 100488.70000000001 us. Raspberry Pi 2 B (900MHz quad-core ARMv7) --profile_period=1000 DeltaBlue(RunTime): 19612.676470588238 us. --profile_period=10000 DeltaBlue(RunTime): 18774.51401869159 us. --profile_period=20000 DeltaBlue(RunTime): 18611.314814814818 us. --profile_period=50000 DeltaBlue(RunTime): 18940.10377358491 us. --profile=false DeltaBlue(RunTime): 18242.463636363635 us. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45432

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M runtime/vm/profiler.cc View 1 chunk +8 lines, -7 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
https://chromiumcodereview.appspot.com/1108123002/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (left): https://chromiumcodereview.appspot.com/1108123002/diff/1/runtime/vm/profiler.cc#oldcode28 runtime/vm/profiler.cc:28: #if defined(TARGET_OS_ANDROID) || defined(HOST_ARCH_ARM64) Why host?
5 years, 7 months ago (2015-04-27 21:06:18 UTC) #2
Cutch
Thanks! LGTM, but, we should watch the bots for fall out. https://chromiumcodereview.appspot.com/1108123002/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (left): ...
5 years, 7 months ago (2015-04-27 21:19:52 UTC) #3
rmacnak
5 years, 7 months ago (2015-04-27 21:45:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45432 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698