Issue 11074005: Wrap Window in case it's a window from a different page / frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11074005: Wrap Window in case it's a window from a different page / frame. (Closed)

Created:
8 years, 2 months ago by vsm

Modified:
8 years, 2 months ago

Reviewers:
sra, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Wrap Window in case it's a window from a different page / frame. I also refactored inner_frame_test to explicitly notify if the subframe tests pass or fail. This should make them more robust and (if they break) fail quickly instead of timing out. BUG=1913 Committed: https://code.google.com/p/dart/source/detail?r=13331

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Patch Set 3 : Add comment #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -85 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		19 chunks	+72 lines, -32 lines	0 comments	Download
M	lib/html/scripts/generator.py	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	lib/html/src/dart2js_Conversions.dart	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	lib/html/src/dart2js_DOMImplementation.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
D	lib/html/templates/html/dart2js/impl_IFrameElement.darttemplate	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	lib/html/templates/html/dart2js/impl_LocalWindow.darttemplate	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/html/inner_frame_test.dart	View	1	2 chunks	+88 lines, -31 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

8 years, 2 months ago (2012-10-05 22:54:42 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/11074005/diff/2001/lib/html/src/dart2j...
File lib/html/src/dart2js_Conversions.dart (right):

https://chromiumcodereview.appspot.com/11074005/diff/2001/lib/html/src/dart2j...
lib/html/src/dart2js_Conversions.dart:24: 
Say why Window is intercepted like this (that will also explain why EventTarget
features here, otherwise it looks like that is a separate conversion).

Expand Messages | Collapse Messages