lib/html/scripts/generator.py - Issue 11074005: Wrap Window in case it's a window from a different page / frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/scripts/generator.py

Issue 11074005: Wrap Window in case it's a window from a different page / frame. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add comment Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/html/scripts/generator.py

diff --git a/lib/html/scripts/generator.py b/lib/html/scripts/generator.py

index 0603e01ddae2f97b487e5cc42aa94df1fc042525..c619e61beb9c6148c08f67fe2cc680492a187c66 100644

--- a/lib/html/scripts/generator.py

+++ b/lib/html/scripts/generator.py

@@ -537,6 +537,18 @@ _serialize_SSV = Conversion('_convertDartToNative_SerializedScriptValue',

'Dynamic', 'Dynamic')

dart2js_conversions = {

+ # Wrap non-local Windows. We need to check EventTarget (the base type)

+ # as well. Note, there are no functions that take a non-local Window

+ # as a parameter / setter.

+ 'DOMWindow get':

+ Conversion('_convertNativeToDart_Window', 'Window', 'Window'),

+ 'EventTarget get':

+ Conversion('_convertNativeToDart_EventTarget', 'EventTarget',

+ 'EventTarget'),

+ 'EventTarget set':

+ Conversion('_convertDartToNative_EventTarget', 'EventTarget',

+ 'EventTarget'),

'IDBKey get':

Conversion('_convertNativeToDart_IDBKey', 'Dynamic', 'Dynamic'),

'IDBKey set':

« no previous file with comments | « lib/html/dart2js/html_dart2js.dart ('k') | lib/html/scripts/systemhtml.py » ('j') | no next file with comments »