Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 110703002: Add an instance view page to the vmservice. (Closed)

Created:
7 years ago by turnidge
Modified:
7 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add an instance view page to the vmservice. We can use this view to browse the field values of objects and explore the heap a bit. ---------- Add field lists to the class and instance view pages. Add field-ref and instance-ref elements. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31074

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4145 lines, -5422 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 4 5 6 7 9 chunks +99 lines, -47 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 5 6 7 368 chunks +1375 lines, -2065 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 4 5 6 7 9 chunks +99 lines, -47 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 660 chunks +2344 lines, -3213 lines 0 comments Download
M runtime/bin/vmservice/client/lib/observatory_elements.dart View 1 2 3 4 5 6 7 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/observatory_elements.html View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html View 1 2 3 4 5 6 7 3 chunks +10 lines, -11 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html View 1 chunk +19 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html View 1 chunk +16 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html View 1 2 3 4 5 6 7 2 chunks +4 lines, -29 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html View 1 2 3 4 5 6 7 2 chunks +19 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.h View 1 2 3 4 5 6 7 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 3 chunks +35 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
7 years ago (2013-12-09 22:43:07 UTC) #1
Cutch
lgtm
7 years ago (2013-12-11 00:15:31 UTC) #2
turnidge
7 years ago (2013-12-11 18:03:55 UTC) #3
Message was sent while issue was closed. 
Committed patchset #8 manually as r31074 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698