Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html

Issue 110703002: Add an instance view page to the vmservice. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html
===================================================================
--- runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html (revision 31070)
+++ runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html (working copy)
@@ -1,6 +1,8 @@
<head>
<link rel="import" href="observatory_element.html">
<link rel="import" href="error_view.html">
+ <link rel="import" href="field_ref.html">
+ <link rel="import" href="instance_ref.html">
</head>
<polymer-element name="class-view" extends="observatory-element">
<template>
@@ -8,12 +10,12 @@
<div class="col-md-8 col-md-offset-2">
<div class="panel panel-warning">
<div class="panel-heading">
- {{ cls['user_name'] }} ({{ cls['name'] }})
+ class <strong>{{ cls['user_name'] }}</strong>
<template if="{{ cls['super']['type'] != 'Null' }}">
extends
<a href="{{ app.locationManager.currentIsolateClassLink(cls['super']['id'])}}">
{{ cls['super']['user_name'] }}
- </a>
+ </a>
</template>
<a class="pull-right" href="{{ app.locationManager.currentIsolateObjectLink(cls['library']['id'])}}">
{{ cls['library']['name'] }}
@@ -37,21 +39,18 @@
<tr>
<td>Patch</td><td>{{ cls['patch'] }}</td>
</tr>
+ <tr>
+ <td>VM Name</td><td>{{ cls['name'] }}</td>
+ </tr>
</tbody>
</table>
<template if="{{ cls['error'] == null }}">
<blockquote><strong>Fields</strong></blockquote>
<table class="table table-hover">
- <thead>
- <tr>
- <th>User Name</th>
- <th>VM Name</th>
- </tr>
- </thead>
- <tbody>
+ <tbody>
<tr template repeat="{{ field in cls['fields'] }}">
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['user_name'] }}</a></td>
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['name'] }}</a></td>
+ <td><field-ref app="{{ app }}" field="{{ field }}"></field-ref></td>
+ <td><instance-ref app="{{ app }}" instance="{{ field['value'] }}"></instance-ref></td>
</tr>
</tbody>
</table>

Powered by Google App Engine
This is Rietveld 408576698