Issue 11065014: Override CSSStyleDeclaration.getPropertyValue in general way.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11065014: Override CSSStyleDeclaration.getPropertyValue in general way. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Override CSSStyleDeclaration.getPropertyValue in general way. Hide actual implementation and check returned value. R=efortuna@google.com BUG=5617 Committed: https://code.google.com/p/dart/source/detail?r=13253

Patch Set 3 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -24 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		4 chunks	+7 lines, -9 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		4 chunks	+9 lines, -4 lines	0 comments	Download
M	lib/html/idl/dart/dart.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/html/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View		1 chunk	+3 lines, -7 lines	0 comments	Download
M	lib/html/templates/html/interface/interface_CSSStyleDeclaration.darttemplate	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm with question https://codereview.chromium.org/11065014/diff/1/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11065014/diff/1/lib/html/dart2js/html_dart2js.dart#newcode3136 lib/html/dart2js/html_dart2js.dart:3136: + String getPropertyValue(String propertyName); do we ...

8 years, 2 months ago (2012-10-04 18:12:32 UTC) #2

Anton Muhin

8 years, 2 months ago (2012-10-04 18:20:02 UTC) #3

https://codereview.chromium.org/11065014/diff/1/lib/html/dart2js/html_dart2js...
File lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11065014/diff/1/lib/html/dart2js/html_dart2js...
lib/html/dart2js/html_dart2js.dart:3136: +  String getPropertyValue(String
propertyName);
That sounds like a very good thing to do, thanks a lot.

On 2012/10/04 18:12:32, Emily Fortuna wrote:
> do we want to add the @domName comment to this function or the
_getPropertyValue
> for documentation purposes?

Expand Messages | Collapse Messages

Issue 11065014: Override CSSStyleDeclaration.getPropertyValue in general way. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages