Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: lib/html/dart2js/html_dart2js.dart

Issue 11065014: Override CSSStyleDeclaration.getPropertyValue in general way. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/dart2js/html_dart2js.dart
diff --git a/lib/html/dart2js/html_dart2js.dart b/lib/html/dart2js/html_dart2js.dart
index daf6e9f2bd4d3297f67c603f436870f009198038..c8f9b05122f6472db3d089f8b0868b09d2f44050 100644
--- a/lib/html/dart2js/html_dart2js.dart
+++ b/lib/html/dart2js/html_dart2js.dart
@@ -2334,9 +2334,6 @@ abstract class CSSStyleDeclaration {
/** @domName CSSStyleDeclaration.getPropertyShorthand */
String getPropertyShorthand(String propertyName);
- /** @domName CSSStyleDeclaration.getPropertyValue */
- String getPropertyValue(String propertyName);
-
/** @domName CSSStyleDeclaration.isPropertyImplicit */
bool isPropertyImplicit(String propertyName);
@@ -3136,6 +3133,9 @@ abstract class CSSStyleDeclaration {
/** Sets the value of "font-weight" */
void set fontWeight(var value);
+ /** @domName CSSStyleDeclaration.getPropertyValue. */
+ String getPropertyValue(String propertyName);
+
/** Gets the value of "height" */
String get height;
@@ -4228,6 +4228,8 @@ class _CSSStyleDeclarationImpl implements CSSStyleDeclaration native "*CSSStyleD
String getPropertyShorthand(String propertyName) native;
+ String _getPropertyValue(String propertyName) native "getPropertyValue";
+
bool isPropertyImplicit(String propertyName) native;
String item(int index) native;
@@ -4236,12 +4238,8 @@ class _CSSStyleDeclarationImpl implements CSSStyleDeclaration native "*CSSStyleD
String getPropertyValue(String propertyName) {
- var propValue = JS('Object', '#.getPropertyValue(#)', this, propertyName);
- if (propValue == null) {
- return '';
- } else {
- return propValue;
- }
+ var propValue = _getPropertyValue(propertyName);
+ return propValue != null ? propValue : '';
}
void setProperty(String propertyName, String value, [String priority]) native '''
« no previous file with comments | « no previous file | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698