Issue 11055009: Converting NodeList to List<Node>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11055009: Converting NodeList to List<Node>. (Closed)

Created:
8 years, 2 months ago by blois

Modified:
8 years, 2 months ago

Reviewers:
vsm, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Converting NodeList to List<Node>. This keeps the NodeList class because other classes depend on it (notably RadioNodeList), but converts all APIs over to List<Node>. BUG=2712 Committed: https://code.google.com/p/dart/source/detail?r=13188

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+146 lines, -303 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	46 chunks	+63 lines, -144 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	47 chunks	+62 lines, -143 lines	0 comments	Download
M	lib/html/idl/dart/dart.idl	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	lib/html/scripts/generator.py	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	2 chunks	+5 lines, -1 line	1 comment	Download
M	lib/html/templates/html/impl/impl_DocumentFragment.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/templates/html/impl/impl_Node.darttemplate	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/html/templates/html/impl/impl_NodeList.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/templates/html/interface/interface_Node.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/templates/html/interface/interface_NodeList.darttemplate	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/node_test.dart	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

8 years, 2 months ago (2012-10-03 00:46:21 UTC) #2

this is awesome!
lgtm with the one change mentioned below.

https://codereview.chromium.org/11055009/diff/1/lib/html/scripts/systemhtml.py
File lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11055009/diff/1/lib/html/scripts/systemhtml.p...
lib/html/scripts/systemhtml.py:504: # Special case as NodeList gets converted to
List<Node>.
These lines shouldn't be necessary. You added NodeList in generator.py, which
populates "nativified_classes", which gets checked in line 475 of this file.

Expand Messages | Collapse Messages